Add Additional testing on functionality of the Bandit tool #1005 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assert the initial baseline found results, modify the baseline file to add new candidates,assert there were new results (new candidates found)
OClark23
changed the title
needed for tox package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION
Here we added two additional assertions to verify that the output contains the strings "Files skipped (0):" and "No issues identified. These two strings indicate that no files were skipped during the scan and no issues were identified, respectively, which are expected when there are no new candidates found compared to the baseline
SEVERITY: Low
Testing before implementation
Test, when there are new candidates, found compared with those in the baseline. This should return the new candidate details along with the candidates from the baseline.
Test when a candidate has a # nosec comment added and that candidate was previously flagged as an issue in the baseline. This should not return that candidate in the results.
Test when a candidate has been fixed in the code and should no longer be flagged as an issue in the baseline. This should not return that candidate in the results.