Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable more than one MjViewer instance at a time #217

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ryanjulian
Copy link

This PR contains a feature and a bug fix which allow an rllab user to open more than one MjViewer window at a time.

Bug fix
MjViewer assumes that, once set during MjViewer.start(), the glfw context never changes. This is not true for multiple windows, which share a global glfw context. Each window needs to switch the glfw context to its own window during rendering.

Feature
Add a kwarg to MjViewer which allows the user to change the window title (useful if you're opening more than one).

Both of these could be solved by upgrading mujoco-py to 1.0+, a project I may take on later. For now, these fixes suffice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant