Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next (v1.0.0-rc6) #86

Open
wants to merge 29 commits into
base: master
Choose a base branch
from
Open

Next (v1.0.0-rc6) #86

wants to merge 29 commits into from

Conversation

drkstr101
Copy link
Contributor

@drkstr101 drkstr101 commented Aug 7, 2020 •
edited
Loading

This PR is still a work in progress, and represents an attempt at the 1.0 milestone release. The WIP flag will be removed once the feature set becomes stable.

TODO

  • test failures in cucumber parser
  • implement new formatting rules
  • Investigate other side effects in UI due to parser updates

@drkstr101 drkstr101 mentioned this pull request Aug 15, 2020
Open
@drkstr101
Copy link
Contributor Author

Closes: #76

Aaron R Miller added 4 commits September 5, 2020 16:07
Project/Builder Updates
4e03a5e 
* Version bump to commons
* Removed uneeded feature bundles
* Hamcrest matchers are now loaded from latest Orbit drop
  (see target definition)

Signed-off-by: Aaron R Miller <[email protected]>
Added Natural Language Core
c53e4be 
Signed-off-by: Aaron R Miller <[email protected]>
Integrated Natural Lang into Cucumber and Jbehave editors
21a6c93 
Signed-off-by: Aaron R Miller <[email protected]>
Added additional validation steps to CucumberValidator
8579109 
Signed-off-by: Aaron R Miller <[email protected]>
@drkstr101 drkstr101 changed the title Next (WIP) Next (v1.0.0-rc1) Sep 5, 2020
@drkstr101
Copy link
Contributor Author

@rlogiacco I'm sure I will spot something wrong 10 minutes after I write this, but I believe this is now ready for initial release canidate review. I will still like to spend a day using it on some real projects, but all automated tests are passing at the very least.

Cheers!

@drkstr101 drkstr101 mentioned this pull request Sep 6, 2020
Open
@drkstr101 drkstr101 changed the title Next (v1.0.0-rc1) Next (v1.0.0-rc2) Sep 6, 2020
Aaron R Miller added 2 commits September 6, 2020 16:00
@drkstr101 drkstr101 changed the title Next (v1.0.0-rc2) Next (v1.0.0-rc3) Sep 6, 2020
@drkstr101 drkstr101 mentioned this pull request Sep 7, 2020
Closed
@drkstr101
Copy link
Contributor Author

@rlogiacco FYI I tested the build on a fresh install and I noticed that eclipse would report some compile errors until I went to Windows -> Preferences -> Plugin Development -> Target Platform and select the project as the target.

Also, Tycho/Maven builds do not seem to be correctly initializing the Guice bindings prior to launching the ui tests, resulting in a failure when running mvn clean verify. I originally thought I had made a mistake configuring the bindings, but that doesn't seem to be the case as it also happens on a freshly generated Xtext project as well. I believe the pom.xml in the *.ui.tests bundles needs to be updated so Tycho can be pointed to the CucumberStandAloneSetup, or something of the sorts.

I have started a separate feature branch for step matcher updates, as I did not want to destabilize the release candidate.

Aaron R Miller added 2 commits September 7, 2020 09:41
[autoformat]
e2e3c2a 
Signed-off-by: Aaron R Miller <[email protected]>
Reverted target definition back to eclipse 2020-03
05145aa 
Signed-off-by: Aaron R Miller <[email protected]>
@drkstr101 drkstr101 changed the title Next (v1.0.0-rc3) Next (v1.0.0-rc4) Sep 7, 2020
Cleaned up full_example.feature
d3b264f 
Signed-off-by: Aaron R Miller <[email protected]>
@drkstr101
Copy link
Contributor Author

drkstr101 commented Sep 7, 2020 •
edited
Loading

Oops, I just spotted an issue. It seems like DocString is not getting its lexical highlighting applied. I added it to our full_example.feature.

Never mind, it was an easy fix.

drkstr101
drkstr101 commented Sep 7, 2020
View reviewed changes
...ware.natural.cucumber/src/org/agileware/natural/cucumber/serializer/CucumberSerializer.xtend
import org.eclipse.xtext.nodemodel.util.NodeModelUtils
import org.agileware.natural.cucumber.cucumber.Text

class CucumberSerializer {
Copy link
Contributor Author

@drkstr101 drkstr101 Sep 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CucumberSeriaizer is out of date and needs to be updated to reflect changes to the AST. This is technically only used for debugging purposes at the moment, so not a huge deal. It will be required for two-way serialization to work however.

Also we should maybe utlize Xtend dispatch methods to get rid of all the null checks pepered into the template strings.

drkstr101
drkstr101 commented Sep 7, 2020
View reviewed changes
org.agileware.natural.lang/src/org/agileware/natural/lang/text/TextValueConverterService.java
private STRINGValueConverter stringValueConverter;

@ValueConverter(rule = TextLiterals.STRING)
public IValueConverter<String> STRING_LITERAL() {
Copy link
Contributor Author

@drkstr101 drkstr101 Sep 7, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect name for binding. Should simple be STRING / NUMBER. Technically this doesn't matter until we need to parse RawText literals (EG. perhaps in the stepmatcher updates).

@drkstr101 drkstr101 changed the title Next (v1.0.0-rc4) Next (v1.0.0-rc5) Sep 8, 2020
@drkstr101 drkstr101 mentioned this pull request Sep 9, 2020
Open
@drkstr101 drkstr101 changed the title Next (v1.0.0-rc5) Next (v1.0.0-rc6) Sep 10, 2020
@drkstr101
Copy link
Contributor Author

@rlogiacco 6th time's a charm! haha. Sorry for all the rapid churn. I think we finally have a winner. Any user feedback prior to release would be greatly appreciated! I have only really tested my own personal workflows.

Aaron R Miller added 5 commits September 9, 2020 17:35
Added example for Cucumber Expressions in cucumber-jvm test project
008a326 
Signed-off-by: Aaron R Miller <[email protected]>
Cleaned up pom/feature files
e9ca34e 
Signed-off-by: Aaron R Miller <[email protected]>
Updated CucumberHighlightingTest
bdbae68 
4 / 34 Failing
* number_01
* number_02
* number_09
* number_10

Signed-off-by: Aaron R Miller <[email protected]>
Removed debug println statement
8efff67 
Signed-off-by: Aaron R Miller <[email protected]>
Added semantic highlighting fallback for failed lexical highlighting
b7f23fd 
	TODO: This is technically a parser bug, and should be
	addressed at the root cause.

Signed-off-by: Aaron R Miller <[email protected]>
@drkstr101
Copy link
Contributor Author

@rlogiacco I've posted a fix for failed lexical highlighting due to incorrect parsing of text literals in certain cases.

I also noticed that stepmatcher is being activated on non-java projects. I will need to post a patch for this as well I think, as it's pretty annoying getting all the unneeded warnings.

This was referenced Sep 14, 2020
Open
Open
Open
Open
Open
@drkstr101
Copy link
Contributor Author

@rlogiacco The email I sent you was bounced. Is everything ok over there good friend?

@rlogiacco
Copy link
Owner

rlogiacco commented Oct 23, 2020 via email

@drkstr101
Copy link
Contributor Author

Oh no haha, I just saw the option in the settings and you were the only one I could think of to put. I think it's some kind of "Bus Factor" protection. Good to hear from you, glad you are well!

I sent you an email from my new addresses but it bounced undeliverable. I wonder if it's because it's a new domain and I'm not in your contacts. Shoot off an email to [email protected] when you get a chance.

I may have a few more updates I can slip in here soon.

@rlogiacco
Copy link
Owner

rlogiacco commented Oct 23, 2020 via email

miklossy
miklossy suggested changes Dec 9, 2020
View reviewed changes
Copy link

@miklossy miklossy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look into the PR and recognized that after I execute the GenerateNatural.mwe2 workflow, the org.agileware.natural.lang/plugin.xml_gen file is generated. Its content should be merged into the org.agileware.natural.lang/plugin.xml file to keep consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miklossy miklossy miklossy requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drkstr101 @rlogiacco @miklossy