-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support diffs #7
Conversation
Thank you for the pull request! Generally, the diff doesn't seem very useful for Can you provide an example where the diff is useful when using Regardless, the diff seems very useful for the Unfortunately, there's currently an open bug in mocha (including the latest |
When the expected substring and the actual text do have a lot in common, the diff is useful in determining the difference. Here is a real-life example. I broke my production code by omitting the single quote after the start date. The diff makes it easier to understand the difference. I agree, that "expected" does not match the semantics of A more contrived example: I hope you are convinced that a diff can be useful for PS: Don’t mind my stacktraces. ;) |
Yes, the diffs in your screenshots really look useful. What version of |
Merged into |
"mocha": "~2.0.1", Wow I had no idea that it was the reporter that made the diffs so useful. One more reason to stick with mocha-unfunk-reporter. ;) Originally I started using it because the default reporters were unreadable with my dark color scheme. |
Thank you for both the pull request and the pluck of |
Seems like unfunk-diff is the reason for the better diffs. |
I am working on providing more useful diffs for In light of this, we should warn on the wiki that this is experimental. Speaking of which, are you going to change the wiki or shall I give it a shot and then create a PR? |
It would be great if you could provide a PR after #8 is merged to document the new API. I wouldn't bother with documenting the experimental API. I've added a warning to the release notes of v2.8.0. |
Cp. http://tjholowaychuk.tumblr.com/post/18574009869