Merge pull request #9 from rluisr/accept_internalservererror

Accept Internal Server Error / MySQL 8.0.32

.github/dependabot.yml

@@ -0,0 +1,13 @@
+version: 2
+registries:
+  github-octocat:
+    type: git
+    url: https://github.com
+    username: rluisr
+    password: ${{secrets.MY_GITHUB_PERSONAL_TOKEN}}
+updates:
+  - package-ecosystem: gomod
+    directory: "/"
+    registries:
+      - github-octocat
+    target-branch: "master"

.github/workflows/lint.yml

@@ -0,0 +1,19 @@
+name: lint
+
+on:
+  push:
+  pull_request:
+
+jobs:
+  lint:
+    name: lint
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v3
+        with:
+          go-version-file: 'go.mod'
+          cache: true
+      - uses: golangci/golangci-lint-action@v3
+        with:
+          version: latest

.github/workflows/test.yml

@@ -4,20 +4,8 @@ on:
   push:
 
 jobs:
-  lint:
-    name: Lint
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v2
-      - name: golangci-lint
-        uses: golangci/golangci-lint-action@v2
-        with:
-          version: latest
-
   test:
     name: Test
-    needs: lint
     runs-on: ubuntu-latest
     steps:
       - name: Checkout

Dockerfile_test

@@ -1,4 +1,4 @@
-FROM golang:1.18
+FROM golang:1.20
 
 WORKDIR /go/src/mysqlrouter-go
 COPY . .

README.md

@@ -6,7 +6,7 @@ client for getting mysql-router information.
 
 Supported version
 -----------------
-- 20190715 (8.0.17 - 8.0.29)
+- 20190715 (8.0.17 - 8.0.32)
 
 Enable HTTP Server and REST API
 -------------------------------

client_test.go

@@ -4,8 +4,8 @@ import (
 	"crypto/tls"
 	"crypto/x509"
 	"github.com/stretchr/testify/assert"
-	"io/ioutil"
 	"net/http"
+	"os"
 	"path/filepath"
 	"testing"
 )
@@ -54,7 +54,7 @@ func TestNewClientWithTLS(t *testing.T) {
 		assert.NoError(t, err)
 	}
 
-	caCert, err := ioutil.ReadFile(caPath)
+	caCert, err := os.ReadFile(caPath)
 	if err != nil {
 		assert.NoError(t, err)
 	}

go.mod

@@ -1,6 +1,6 @@
 module github.com/rluisr/mysqlrouter-go
 
-go 1.18
+go 1.20
 
 require github.com/stretchr/testify v1.6.1
 

request.go

@@ -2,7 +2,7 @@ package mysqlrouter
 
 import (
 	"fmt"
-	"io/ioutil"
+	"io"
 	"net/http"
 )
 
@@ -30,9 +30,10 @@ func (c *Client) request(url string) ([]byte, error) {
 	}
 	defer resp.Body.Close()
 
-	if resp.StatusCode != 200 {
+	// We accept InternalServerError because MySQL Router REST API return 500 when route status does not alive. see: https://github.com/rluisr/mysqlrouter_exporter/issues/30#issue-1703518829
+	if resp.StatusCode != http.StatusOK && resp.StatusCode != http.StatusInternalServerError {
 		return nil, fmt.Errorf("%s got %d", errStatusCode, resp.StatusCode)
 	}
 
-	return ioutil.ReadAll(resp.Body)
+	return io.ReadAll(resp.Body)
 }

test/.env

@@ -1 +1 @@
-VERSION=8.0.29
+VERSION=8.0.32