Skip to content

Commit

Permalink
Merge pull request #3395 from mattvague/patch-2
Browse files Browse the repository at this point in the history 
Move graphql and @apollo/client to peerDeps
  • Loading branch information
Robert Mosolgo authored Mar 31, 2021
2 parents dcd0e11 + 0f73586 commit d7e5c04
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions javascript_client/package.json
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,14 @@
"prepublishOnly": "tsc"
},
"dependencies": {
"@apollo/client": "^3.3.6",
"glob": "^7.1.4",
"graphql": "^14.3.1 || ^15.0.0",
"minimist": "^1.2.0",
"request": "^2.88.2"
},
"peerDependencies": {
"@apollo/client": "^3.3.6",
"graphql": "^14.3.1 || ^15.0.0"
},
"prettier": {
"semi": false,
"trailingComma": "none"
Expand Down

1 comment on commit d7e5c04

@KieranP
Copy link

@KieranP KieranP commented on d7e5c04 Apr 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rmosolgo This broke things. When upgrading this package, this is the output in yarn.lock:

 graphql-ruby-client@^1.8.1:
-  version "1.9.2"
-  resolved "https://registry.yarnpkg.com/graphql-ruby-client/-/graphql-ruby-client-1.9.2.tgz#177304b0a4b3479942acfa9ae874ddd83e095052"
-  integrity sha512-LJBx02t8YXGhzyNYaT2XlKqXJ5mEBv2vilfBIfdjAFioyP3y7pehPqcCLCHtHZHqSreLP8S3v1hfeO1XWc+tJA==
+  version "1.9.3"
+  resolved "https://registry.yarnpkg.com/graphql-ruby-client/-/graphql-ruby-client-1.9.3.tgz#bbaa81481146540aca681b2f98c9efafb394abac"
+  integrity sha512-tcUuk0dwRIrgYaCou3JOuBDOLeBkXQ3U5KxMNKlrqzja0hb9TdAnPOqCCpVupU65zQi5aZW2Z/aZYrFZAFQmyg==
   dependencies:
-    "@apollo/client" "^3.3.6"
-    "@types/actioncable" "^5.2.3"
-    "@types/pusher-js" "^4.2.2"
     glob "^7.1.4"
-    graphql "^14.3.1 || ^15.0.0"
     minimist "^1.2.0"
     request "^2.88.2"
-    typescript "^3.7.5"

It removed the @apollo/client and graphql dependencies which this JS package depends on to run.

I can work around it by adding "graphql" to my package.json, but this package really should declare them as full dependencies.

Please sign in to comment.