Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move typescript & @types packages to dev dependencies #3391

Merged
merged 1 commit into from
Mar 15, 2021

Conversation

mattvague
Copy link
Contributor

Since the graphql-ruby-client package on npm is compiled via tsc, typescript should not be required to run it and therefore I believe typescript, and any @types/** packages should be a dev dependencies instead of a regular dependencies. As it it now, it adds an extra 60ish mb your bundle if using graphql-ruby-client.

@mattvague mattvague changed the title Update package.json Move typescript & @types packages to dev dependencies Mar 15, 2021
@rmosolgo
Copy link
Owner

Good catch -- thanks for the improvement!

@rmosolgo rmosolgo merged commit 5c3a8ec into rmosolgo:master Mar 15, 2021
@mattvague
Copy link
Contributor Author

Good catch -- thanks for the improvement!

@rmosolgo No problemo, thank you for the excellent library! On the same topic, I was wondering if maybe @apollo/client and graphql should be peerDependencies instead so you're not risking having multiple versions / a version conflict in someone's app? If that sounds right am happy to PR that

@rmosolgo
Copy link
Owner

I think that'd be fine!

@mattvague
Copy link
Contributor Author

I think that'd be fine!

The only issue is that the new version of graphql-ruby-client would break peoples apps and force them to add those dips if they weren't already including @apollo/client and graphql for some reason.

@mattvague mattvague deleted the fix-package-json branch March 16, 2021 15:19
@rmosolgo
Copy link
Owner

That'd be fine -- I'll mention it in the changelog and bump the version. It's easy to fix and breaks loudly, so I don't think anyone would be surprised by bugs in production. Thanks for thinking it through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants