Allow variable definition directives in validation #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adampetro
force-pushed
the
support-variable-definition-directives
branch
from
7c6f43d
to
ee4daa8
Compare
adampetro
force-pushed
the
support-variable-definition-directives
branch
from
ee4daa8
to
493416a
Compare
|
Thanks for this improvement! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow variable definition directives in the
DirectivesAreInValidLocationsstatic validation rule.This also adds a test, but it feels a bit odd that it only tests the variable definition case and no others. I could remove the test, or add cases to cover more of the possible valid locations.