Update example readme #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Project setup explanation is not correct. A postinstall hook automatically creates the env.json file. Instead, an `access` file needs to be provided.
|
It was changed at https://github.com/react-native-mapbox-gl/maps/pull/224 @arnaudambro, @henninghall can you agree on the correct solution?! Was one of you using yarn the other npm?! |
|
Tried both yarn and npm and both creates an env.json file for me. |
|
This PR is correct. You make a file called |
|
@henninghall what do you think about adding a small note that |
Add note in example readme to explain that you need to run npm install after chaning accesstoken file
mfazekas
approved these changes
Aug 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Example project setup explanation is not correct. A postinstall hook automatically creates the env.json file. Instead, a file named
accessfile needs to be provided.