Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: regenerate temporal and overall proto #60

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Conversation

rustatian
Copy link
Member

@rustatian rustatian commented Feb 17, 2024

Reason for This PR

  • Temporal proto v1.27.
  • Gogo proto is deprecated.

Description of Changes

  • Remove gogo proto dep.
  • Update Temporal proto to v1.27.0

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

Summary by CodeRabbit

  • Refactor
    • Simplified HTTP request handling by consolidating query fields in the API.
  • Chores
    • Updated third-party API to the latest version for enhanced functionality and security.

@rustatian rustatian added A-other Area: other C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc.. labels Feb 17, 2024
@rustatian rustatian self-assigned this Feb 17, 2024
Copy link

coderabbitai bot commented Feb 17, 2024

Warning

Rate Limit Exceeded

@rustatian has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 23 minutes and 50 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits Files that changed from the base of the PR and between baa278f and b1ce856.

Walkthrough

The recent modifications involve streamlining the http.proto file by simplifying the Request message structure, focusing on a more unified query representation through the form_query field. Concurrently, the project's dependencies have been updated by altering the commit reference of a third-party API, ensuring compatibility and leveraging newer functionalities or fixes that come with the updated version.

Changes

File Path Change Summary
proto/http/v1beta/http.proto Replaced raw_query, parsed, and attributes with form_query; Commented out body and raw_body
third_party/api Updated subproject commit reference from a19522ade6a4e3ee120cc3e7c8390bb9b4aecf75 to 822966d29758cba3462d6f5ff198257fbaa426f6

🐰✨
In the land of code and byte,
Changes come both day and night.
Fields retire, new ones greet,
With every merge, our goals meet.
Together we hop, in sync, complete.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 08832e6 and baa278f.
Files ignored due to path filters (56)
  • buf.gen.yaml is excluded by: !**/*.yaml
  • buf.lock is excluded by: !**/*.lock
  • buf.yaml is excluded by: !**/*.yaml
  • build/applogger/v1/applogger.pb.go is excluded by: !**/*.pb.go
  • build/centrifugo/api/v1/api.pb.go is excluded by: !**/*.pb.go
  • build/centrifugo/proxy/v1/proxy.pb.go is excluded by: !**/*.pb.go
  • build/common/v1/grpc_status.pb.go is excluded by: !**/*.pb.go
  • build/http/v1beta/http.pb.go is excluded by: !**/*.pb.go
  • build/jobs/v1/jobs.pb.go is excluded by: !**/*.pb.go
  • build/kv/v1/kv.pb.go is excluded by: !**/*.pb.go
  • build/lock/v1beta1/lock.pb.go is excluded by: !**/*.pb.go
  • build/service/v1/service.pb.go is excluded by: !**/*.pb.go
  • build/status/v1/status.pb.go is excluded by: !**/*.pb.go
  • build/status/v1beta1/status.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/batch/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/command/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/common/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/batch_operation.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/command_type.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/common.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/event_type.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/failed_cause.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/namespace.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/query.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/reset.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/schedule.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/task_queue.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/update.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/enums/v1/workflow.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/errordetails/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/export/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/failure/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/filter/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/history/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/namespace/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/nexus/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/operatorservice/v1/request_response.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/operatorservice/v1/service.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/operatorservice/v1/service_grpc.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/protocol/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/query/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/replication/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/schedule/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/sdk/v1/task_complete_metadata.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/sdk/v1/workflow_metadata.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/taskqueue/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/update/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/version/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/workflow/v1/message.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/workflowservice/v1/request_response.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/workflowservice/v1/service.pb.go is excluded by: !**/*.pb.go
  • build/temporal/api/workflowservice/v1/service_grpc.pb.go is excluded by: !**/*.pb.go
  • build/temporal/v1/temporal.pb.go is excluded by: !**/*.pb.go
  • build/websockets/v1/websockets.pb.go is excluded by: !**/*.pb.go
  • proto/buf.lock is excluded by: !**/*.lock
  • proto/buf.yaml is excluded by: !**/*.yaml
Files selected for processing (2)
  • proto/http/v1beta/http.proto (1 hunks)
  • third_party/api (1 hunks)
Files skipped from review due to trivial changes (1)
  • third_party/api
Additional comments: 2
proto/http/v1beta/http.proto (2)
  • 18-18: The addition of the form_query field as a map of HeaderValue is a significant change. It's important to ensure that all server-side code that processes requests is updated to handle this new field. This change could impact how query parameters are parsed and used throughout the application.
  • 20-24: Commenting out the raw_query, parsed, attributes, body, and raw_body fields represents a major shift in how HTTP requests are handled. This could have wide-ranging implications for any functionality that relied on these fields. It's crucial to verify that all necessary adjustments have been made in the codebase to accommodate this change and that no critical functionality is lost as a result.

Signed-off-by: Valery Piashchynski <[email protected]>
Signed-off-by: Valery Piashchynski <[email protected]>
@rustatian rustatian merged commit f27dc55 into master Feb 17, 2024
@rustatian rustatian deleted the feature/update-proto branch February 17, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-other Area: other C-enhancement Category: enhancement. Meaning improvements of current module, transport, etc..
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

1 participant