feature: enhance CORS support
#48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmikalkenas
force-pushed
the
enhance-cors-support
branch
2 times, most recently
from
a6ac9db
to
65bc7c7
Compare
|
Hey @rmikalkenas 👋🏻 Thanks for the PR 👍🏻 |
rustatian
requested changes
Jun 16, 2023
|
If you have any additional questions - feel free to ping me here or in the our Discord server 👍🏻 |
rmikalkenas
force-pushed
the
enhance-cors-support
branch
2 times, most recently
from
a2e57a5
to
68794e8
Compare
@rustatian thanks for the comments 👍 updated the PR. Let me know what you think |
rustatian
requested changes
Jun 18, 2023
rmikalkenas
force-pushed
the
enhance-cors-support
branch
from
68794e8
to
b8c2bb6
Compare
Signed-off-by: Rokas Mikalkėnas <[email protected]>
rmikalkenas
force-pushed
the
enhance-cors-support
branch
from
b8c2bb6
to
77fdb0d
Compare
rustatian
approved these changes
Jun 19, 2023
This was referenced Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for This PR
roadrunner-server/roadrunner#909
Description of Changes
P.S. will update docs that
allowed_originnow accepts multiple values separated by comma (if this PR gets approval)License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.