Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: jobs workers status #81

Merged
merged 2 commits into from
Jun 12, 2023
Merged

Conversation

Kaspiman
Copy link
Sponsor Contributor

@Kaspiman Kaspiman commented Jun 8, 2023

Reason for This PR

roadrunner-server/roadrunner#1582 (comment)

Description of Changes

Copy-paste from HTTP plugin

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian changed the title Jobs Status feature: jobs workers status Jun 8, 2023
@rustatian
Copy link
Member

Hey @Kaspiman 👋🏻 Thanks for the PR 👍🏻
The second part is tests: https://github.com/roadrunner-server/rr-e2e-tests
Should be added here: https://github.com/roadrunner-server/rr-e2e-tests/blob/master/plugins/status/plugin_test.go
Feel free to ping me in Discord or here if you have any questions.

@rustatian rustatian self-requested a review June 8, 2023 08:02
@rustatian rustatian added the enhancement New feature or request label Jun 8, 2023
@rustatian rustatian marked this pull request as draft June 8, 2023 08:02
@Kaspiman
Copy link
Sponsor Contributor Author

Kaspiman commented Jun 8, 2023

Hi! I'm already wortking on https://github.com/roadrunner-server/rr-e2e-tests/blob/master/plugins/status/plugin_test.go.

Do i need to wait merging this MR?

@rustatian
Copy link
Member

@Kaspiman Not really, you can use replace to replace the remote plugin with your local copy: https://go.dev/ref/mod#go-mod-file-replace
Then you can test your changes before pushing the tag back to the source.

@Kaspiman Kaspiman marked this pull request as ready for review June 12, 2023 09:01
Copy link
Member

@rustatian rustatian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants