Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: take into account pool's deadline option #43

Merged
merged 1 commit into from
May 20, 2023

Conversation

rustatian
Copy link
Member

Reason for This PR

closes: roadrunner-server/roadrunner#1567

Description of Changes

  • Get correct timeout from the pool configuration options.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.

PR Checklist

[Author TODO: Meet these criteria.]
[Reviewer TODO: Verify that these criteria are met. Request changes if not]

  • All commits in this PR are signed (git commit -s).
  • The reason for this PR is clearly provided (issue no. or explanation).
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • Any user-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.

@rustatian rustatian added the bug Something isn't working label May 20, 2023
@rustatian rustatian requested a review from wolfy-j May 20, 2023 17:31
@rustatian rustatian self-assigned this May 20, 2023
@rustatian rustatian merged commit 4adae51 into master May 20, 2023
@rustatian rustatian deleted the fix/get-deadline-from-pool branch May 20, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[🐛 BUG]: Safe shutdown of workers occurs before the specified time through a process kill
1 participant