chore: remove pools shutdown policy #88
Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
WalkthroughThe changes involve modifications to the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Makefile
participant Plugin
User->>Makefile: Run `make test`
Makefile->>Plugin: Execute `go test -tags=race,debug`
Plugin->>Plugin: Run tests with new configuration
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
rustatian
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- .golangci.yml (1 hunks)
- Makefile (1 hunks)
- plugin.go (5 hunks)
Additional comments not posted (2)
.golangci.yml (1)
43-43: Approve linter change but verify effectiveness.The replacement of
exportlooprefwithcopyloopvaris noted. Ensure that the new lintercopyloopvareffectively catches issues related to pointers to enclosing loop variables as intended.The code changes are approved.
Run the following script to verify the effectiveness of the new linter:
plugin.go (1)
112-112: Approve method simplification but verify overall impact.The simplification of the
Stopmethod by removing thecontext.Contextparameter and the synchronization logic is noted. Verify that this change aligns with the new architecture and does not adversely affect the plugin's functionality.The code changes are approved.
Run the following script to verify the overall impact on the plugin's functionality:
| go test -v -race -cover -tags=race -tags=debug ./... |
There was a problem hiding this comment.
Merge tags in the test command.
The go test command includes -tags=race and -tags=debug separately, which might not work as intended because the last -tags option will override the previous one. Merge them into a single -tags option to enable both features simultaneously.
Apply this diff to fix the command:
- go test -v -race -cover -tags=race -tags=debug ./...
+ go test -v -race -cover -tags="race,debug" ./...Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| test: | |
| go test -v -race -cover -tags=race -tags=debug ./... | |
| test: | |
| go test -v -race -cover -tags="race,debug" ./... |
Reason for This PR
ref: roadrunner-server/roadrunner#1986
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.Summary by CodeRabbit
New Features
Bug Fixes
Refactor
Pluginstruct by removing thepoolsslice and adjusting theStopmethod signature.