-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sensor: Emit entities for new fields from the TCP backend #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [TCP backend in python-omnikinverter] emits, in addition to existing fields (but without any info on the WiFi "Device"): - Inverter temparature; - Total hours of inverter uptime; - Voltage and current of a total of 3 DC input strings; - Voltage, current, frequency and power for AC output (also 3...). [TCP backend in python-omnikinverter]: klaasnicolaas/python-omnikinverter#134 This requires new types here as the DC input and AC output values are provided in arrays.
robbinjanssen
approved these changes
May 16, 2022
MarijnS95
commented
May 16, 2022
MarijnS95
commented
May 16, 2022
Co-authored-by: Klaas Schoute <[email protected]>
MarijnS95
commented
May 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TCP backend in python-omnikinverter emits, in addition to existing fields (but without any info on the WiFi "Device"):
This requires new types here as the DC input and AC output values are provided in arrays.