Improve aspcore DB benchmarks (TechEmpower#4015)

* Update .NET MySQL benchmarks to latest MySqlConnector version. * Update optimized connection string settings for MySqlConnector. * Use prepared commands with MySqlConnector. * Update npgsql to latest version.
roberthusak · Nov 6, 2018 · 038b927 · 038b927
1 parent e0c6e25
commit 038b927
Show file tree

Hide file tree

Showing 10 changed files with 33 additions and 26 deletions.
diff --git a/frameworks/CSharp/aspnetcore-mono/Benchmarks/Benchmarks.csproj b/frameworks/CSharp/aspnetcore-mono/Benchmarks/Benchmarks.csproj
@@ -16,20 +16,19 @@
   </ItemGroup>
 
   <ItemGroup>
-    <PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.1.0-rc1-final" />
-    <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.1.0-rc1-final" />
-    <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.1.0-rc1-final" />
-    <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.1.0-rc1-final" />
-    <PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.0-rc1-final" />
-    <PackageReference Include="Microsoft.Extensions.Configuration.CommandLine" Version="2.1.0-rc1-final" />
-    <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="2.1.0-rc1-final" />
-    <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.1.0-rc1-final" />
-    <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="2.1.0-rc1-final" />
-    <!-- Fix https://github.com/aspnet/KestrelHttpServer/pull/2562  -->
-    <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets" Version="2.1.0-rtm-30793" />
-    <PackageReference Include="MySqlConnector" Version="0.40.3" />
-    <PackageReference Include="Npgsql" Version="4.0.0-rc1" />
-    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="2.1.0-rc1" />
+    <PackageReference Include="Microsoft.AspNetCore.Hosting" Version="2.1.1" />
+    <PackageReference Include="Microsoft.AspNetCore.Mvc" Version="2.1.2" />
+    <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel" Version="2.1.3" />
+    <PackageReference Include="Microsoft.AspNetCore.StaticFiles" Version="2.1.1" />
+    <PackageReference Include="Microsoft.Extensions.Configuration" Version="2.1.1" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.CommandLine" Version="2.1.1" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.EnvironmentVariables" Version="2.1.1" />
+    <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.1.1" />
+    <PackageReference Include="Microsoft.Extensions.Options.ConfigurationExtensions" Version="2.1.1" />
+    <PackageReference Include="Microsoft.AspNetCore.Server.Kestrel.Transport.Sockets" Version="2.1.3" />
+    <PackageReference Include="MySqlConnector" Version="0.44.1" />
+    <PackageReference Include="Npgsql" Version="4.0.2" />
+    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="2.1.1.1" />
   </ItemGroup>
 
   <ItemGroup Condition=" '$(TargetFramework)' == 'net471' ">

diff --git a/frameworks/CSharp/aspnetcore-mono/PlatformBenchmarks/PlatformBenchmarks.csproj b/frameworks/CSharp/aspnetcore-mono/PlatformBenchmarks/PlatformBenchmarks.csproj
@@ -18,8 +18,8 @@
     <PackageReference Include="Microsoft.Extensions.Configuration.CommandLine" Version="2.1.0-rc1-final" />
     <PackageReference Include="Microsoft.Extensions.Configuration.Json" Version="2.1.0-rc1-final" />
     <PackageReference Include="Utf8Json" Version="1.3.7" />
-    <PackageReference Include="Npgsql" Version="4.0.0-rc1" />
-    <PackageReference Include="MySqlConnector" Version="0.40.3" />
+    <PackageReference Include="Npgsql" Version="4.0.2" />
+    <PackageReference Include="MySqlConnector" Version="0.44.1" />
   </ItemGroup>
 
   <ItemGroup Condition=" '$(TargetFramework)' == 'net471' ">

diff --git a/frameworks/CSharp/aspnetcore/Benchmarks/Benchmarks.csproj b/frameworks/CSharp/aspnetcore/Benchmarks/Benchmarks.csproj
@@ -14,9 +14,9 @@
   <ItemGroup>
     <PackageReference Include="Microsoft.AspNetCore.App" />
     <PackageReference Include="Dapper" Version="1.50.4" />
-    <PackageReference Include="MySqlConnector" Version="0.40.3" />
-    <PackageReference Include="Npgsql" Version="4.0.0-rc1" />
-    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="2.1.0-rc1" />
+    <PackageReference Include="MySqlConnector" Version="0.44.1" />
+    <PackageReference Include="Npgsql" Version="4.0.2" />
+    <PackageReference Include="Npgsql.EntityFrameworkCore.PostgreSQL" Version="2.1.1.1" />
     <PackageReference Include="SpanJson" Version="1.2.2" />
     <PackageReference Include="Utf8Json" Version="1.3.7" />
   </ItemGroup>

diff --git a/frameworks/CSharp/aspnetcore/Benchmarks/Data/RawDb.cs b/frameworks/CSharp/aspnetcore/Benchmarks/Data/RawDb.cs
@@ -64,6 +64,8 @@ DbCommand CreateReadCommand(DbConnection connection)
             id.Value = _random.Next(1, 10001);
             cmd.Parameters.Add(id);
 
+            (cmd as MySql.Data.MySqlClient.MySqlCommand)?.Prepare();
+
             return cmd;
         }
 
@@ -147,6 +149,8 @@ public async Task<IEnumerable<Fortune>> LoadFortunesRows()
                 db.ConnectionString = _connectionString;
                 await db.OpenAsync();
 
+                (cmd as MySql.Data.MySqlClient.MySqlCommand)?.Prepare();
+
                 using (var rdr = await cmd.ExecuteReaderAsync(CommandBehavior.CloseConnection))
                 {
                     while (await rdr.ReadAsync())

diff --git a/frameworks/CSharp/aspnetcore/Benchmarks/appsettings.mysql.json b/frameworks/CSharp/aspnetcore/Benchmarks/appsettings.mysql.json
@@ -1,4 +1,4 @@
 {
-  "ConnectionString": "Server=tfb-database;Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=1024;SslMode=None;ConnectionReset=false;ConnectionIdlePingTime=900;ConnectionIdleTimeout=0",
+  "ConnectionString": "Server=tfb-database;Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=1024;SslMode=None;ConnectionReset=false;ConnectionIdlePingTime=900;ConnectionIdleTimeout=0;AutoEnlist=false;DefaultCommandTimeout=0;ConnectionTimeout=0;IgnorePrepare=false;",
   "Database": "mysql"
 }
diff --git a/frameworks/CSharp/aspnetcore/PlatformBenchmarks/Data/RawDb.cs b/frameworks/CSharp/aspnetcore/PlatformBenchmarks/Data/RawDb.cs
@@ -62,6 +62,8 @@ DbCommand CreateReadCommand(DbConnection connection)
             id.Value = _random.Next(1, 10001);
             cmd.Parameters.Add(id);
 
+            (cmd as MySql.Data.MySqlClient.MySqlCommand)?.Prepare();
+
             return cmd;
         }
 
@@ -146,6 +148,8 @@ public async Task<List<Fortune>> LoadFortunesRows()
                 db.ConnectionString = _connectionString;
                 await db.OpenAsync();
 
+                (cmd as MySql.Data.MySqlClient.MySqlCommand)?.Prepare();
+
                 using (var rdr = await cmd.ExecuteReaderAsync(CommandBehavior.CloseConnection))
                 {
                     while (await rdr.ReadAsync())

diff --git a/frameworks/CSharp/aspnetcore/PlatformBenchmarks/PlatformBenchmarks.csproj b/frameworks/CSharp/aspnetcore/PlatformBenchmarks/PlatformBenchmarks.csproj
@@ -13,8 +13,8 @@
 
   <ItemGroup>
     <PackageReference Include="Utf8Json" Version="1.3.7" />
-    <PackageReference Include="Npgsql" Version="4.0.0-rc1" />
-    <PackageReference Include="MySqlConnector" Version="0.40.3" />
+    <PackageReference Include="Npgsql" Version="4.0.2" />
+    <PackageReference Include="MySqlConnector" Version="0.44.1" />
     <PackageReference Include="Microsoft.AspNetCore.All" />
   </ItemGroup>
 </Project>
diff --git a/frameworks/CSharp/nancy/src/NancyBenchmark.csproj b/frameworks/CSharp/nancy/src/NancyBenchmark.csproj
@@ -21,7 +21,7 @@
 
   <ItemGroup>
     <PackageReference Include="Nancy" Version="2.0.0-pre1909" />
-    <PackageReference Include="MySqlConnector" Version="0.40.3" />
+    <PackageReference Include="MySqlConnector" Version="0.44.1" />
     <PackageReference Include="Dapper" Version="1.50.4" />
   </ItemGroup>
 

diff --git a/frameworks/VB/aspnetcore/Benchmarks/Benchmarks.vbproj b/frameworks/VB/aspnetcore/Benchmarks/Benchmarks.vbproj
@@ -11,8 +11,8 @@
 
   <ItemGroup>
     <PackageReference Include="Utf8Json" Version="1.3.7" />
-    <PackageReference Include="Npgsql" Version="4.0.1" />
-    <PackageReference Include="MySqlConnector" Version="0.42.2" />
+    <PackageReference Include="Npgsql" Version="4.0.2" />
+    <PackageReference Include="MySqlConnector" Version="0.44.1" />
     <PackageReference Include="Microsoft.AspNetCore.App" />
   </ItemGroup>
 

diff --git a/frameworks/VB/aspnetcore/Benchmarks/appsettings.mysql.json b/frameworks/VB/aspnetcore/Benchmarks/appsettings.mysql.json
@@ -1,4 +1,4 @@
 {
-  "ConnectionString": "Server=tfb-database;Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=1024;SslMode=None;ConnectionReset=false;ConnectionIdlePingTime=900;ConnectionIdleTimeout=0",
+  "ConnectionString": "Server=tfb-database;Database=hello_world;User Id=benchmarkdbuser;Password=benchmarkdbpass;Maximum Pool Size=1024;SslMode=None;ConnectionReset=false;ConnectionIdlePingTime=900;ConnectionIdleTimeout=0;AutoEnlist=false;DefaultCommandTimeout=0;ConnectionTimeout=0;",
   "Database": "mysql"
 }