Convert operators to use tensor pool, part 2 #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This bound was referenced in a safety comment, but was missing.
Some operators built up their output by filling a `Vec<T>` and passing that to `Tensor::from_data`. Being able to allocate an empty Vec from the pool with a given capacity supports this.
Use the new `alloc_vec` API to allocate the output buffer, avoiding unsafe code in `Concat` itself.
This operator still uses the global allocator internally for the `col2im_mat` temporary buffer.
…ropped This is useful for operators which allocate temporary buffers from the pool and need to return them at the end.
robertknight
force-pushed
the
pool-alloc-pt2
branch
from
3247ba0
to
8a2726c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert the
Reshape,MatMul,Where,TileandConvTransposeoperators to allocate from the shared pool.In the process, add some general new facilities to
TensorPool:Vecwith a given capacityPoolRefsmart pointer which wraps a tensor and returns it to the pool when it goes out of scope. This is useful for temporary buffers allocate within operators, such as the col2im matrix inConvTranspose.See #109