Support Object.values() #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems likely we need to bump the Go version of this project - I can do that this week |
stevenh
requested changes
Apr 11, 2024
rorymalcolm
force-pushed
the
rorymalcolm/support-object-values-keys
branch
from
728f0da
to
c4200f1
Compare
Applied! |
stevenh
approved these changes
Apr 12, 2024
|
Could you rebase to pickup the fix for the check failures please @rorymalcolm |
This adds support for `Object.values()`, alongside tests
rorymalcolm
force-pushed
the
rorymalcolm/support-object-values-keys
branch
from
c4200f1
to
946c802
Compare
Done - was going to try get rorymalcolm#1 up today but you beat me to it - thanks so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
Object.values(), alongside tests