Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
rust-lang/rust#98835 fixes a rustc bug that makes it incorrectly accepts the following code:
The crater run found that figma-asset-downloader relies on this bug. I'm not sure when this change reaches stable, if ever, but it's better to not rely on such a bug. This PR tries to fix this.
If you have an opinion on this change, please let me know here or by commenting on the PR.
You can install and test the toolchain locally by running the command:
rustup-toolchain-install-master cb1f7c96119295882e08b09b4bd01051669c071b
Edit: here is the error output when compiling
figma-asset-downloader
: https://crater-reports.s3.amazonaws.com/pr-98835/try%23cb1f7c96119295882e08b09b4bd01051669c071b/reg/figma-asset-downloader-0.9.0/log.txt