Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let cron depend on interface for parsers instead of fixed parser #243

Merged
merged 1 commit into from
Nov 25, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion cron.go
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,16 @@ type Cron struct {
logger Logger
runningMu sync.Mutex
location *time.Location
parser Parser
parser ScheduleParser
nextID EntryID
jobWaiter sync.WaitGroup
}

// ScheduleParser is an interface for schedule spec parsers that return a Schedule
type ScheduleParser interface {
Parse(spec string) (Schedule, error)
}

// Job is an interface for submitted cron jobs.
type Job interface {
Run()
Expand Down
2 changes: 1 addition & 1 deletion option.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func WithSeconds() Option {
}

// WithParser overrides the parser used for interpreting job schedules.
func WithParser(p Parser) Option {
func WithParser(p ScheduleParser) Option {
return func(c *Cron) {
c.parser = p
}
Expand Down