Allow setting the start time of a ConstantDelaySchedule #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will close robfig#336
fatihtekin-form3
approved these changes
Mar 2, 2021
* If the start time is in the future, use it as the first run instead of returning a zero date. Otherwise the entry might never run if there are no other entries with non-zero dates. * Round the start time to the second as when the next time is calculated it's rounded too and might end up before the time passed as input. In this case the entry will be run thousands of times as the next timestamp is before `now` Co-authored-by: Fatih Tekin <[email protected]>
geodimm
force-pushed
the
add-start-time-to-constantdelay-schedules
branch
from
cb22499
to
e5535a0
Compare
SamPeng87
pushed a commit
to SamPeng87/cron
that referenced
this pull request
May 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will close #336