Fix Promise.all/allSettled/race/some/any #140
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `all` no longer accepts non-promises in the input array - `allSettled` now preserves array/tuple length where possible - `some` can take in a positive, non-decimal numeric literal type and convert it to a tuple of the right length. - `all`/`allSettled`/`race`/`some`/`any` now all: - accept readonly arrays, since these methods don't mutate in-place - accept arrays with different Promise types in them, e.g. `[Promise<number>, Promise<string>]` now works - for `race`/`any`, we transform `[Promise<number>, Promise<string>]` into `Promise<number | string>` rather than `Promise<number> | Promise<string>`. For `some` it is the same but an array: `Promise<(number | string)[]>`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
allno longer accepts non-promises in the input arrayallSettlednow preserves array/tuple length where possiblesomecan take in a positive, non-decimal numeric literal type and convert it to a tuple of the right length.all/allSettled/race/some/anynow all:[Promise<number>, Promise<string>]now worksrace/any, we transform[Promise<number>, Promise<string>]intoPromise<number | string>rather thanPromise<number> | Promise<string>. Forsomeit is the same but an array:Promise<(number | string)[]>As opposed to #138, this PR does not publicly expose BuildTuple.