Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mutable default value 1817 #1859

Merged
merged 5 commits into from
Nov 18, 2023
Merged

Mutable default value 1817 #1859

merged 5 commits into from
Nov 18, 2023

Conversation

emanlove
Copy link
Member

Fixes issues with mutable default values.

@emanlove emanlove added this to the v6.1.4 milestone Nov 17, 2023
@emanlove emanlove added bug priority: high acknowledge To be acknowledged in release notes labels Nov 17, 2023
Snooz82
Snooz82 requested changes Nov 17, 2023
View reviewed changes
Copy link
Member

@Snooz82 Snooz82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two comments.
The type hint is important. Otherwise it will use the default as type hint.

src/SeleniumLibrary/keywords/browsermanagement.py Outdated Show resolved Hide resolved
src/SeleniumLibrary/keywords/browsermanagement.py Show resolved Hide resolved
yuriverweij
yuriverweij reviewed Nov 17, 2023
View reviewed changes
Copy link
Member

@yuriverweij yuriverweij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Snooz82, nothing else to add

Snooz82
Snooz82 approved these changes Nov 18, 2023
View reviewed changes
Copy link
Member

@Snooz82 Snooz82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@emanlove
Copy link
Member Author

The failing rf v6.1.1 failing test is unrelated so proceeding with the merge of this fix ..

@emanlove emanlove marked this pull request as ready for review November 18, 2023 15:25
@emanlove emanlove merged commit 68edcfe into robotframework:master Nov 18, 2023
6 of 8 checks passed
@emanlove emanlove mentioned this pull request Nov 18, 2023
Closed
@emanlove emanlove removed this from the v6.1.4 milestone Nov 19, 2023
@emanlove emanlove deleted the mutable-default-value-1817 branch December 19, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuriverweij yuriverweij yuriverweij left review comments

@Snooz82 Snooz82 Snooz82 approved these changes

@aaltat aaltat Awaiting requested review from aaltat

Assignees
No one assigned
Labels
acknowledge To be acknowledged in release notes bug priority: high
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emanlove @yuriverweij @Snooz82