Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix include directories in SWIG bindings #358

Merged
merged 1 commit into from
May 22, 2021
Merged

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented May 22, 2021

For some reason, the first -I compiler option passed to compile the bindings is a system folder, and if the CMake project is installed, the installed headers are included in the bindings. This is not a big problem in most cases, but it could create problems when the public headers change while developing because SWIG would generate the bindings with the installed ones instead of the new in-source updated headers.

This minor change of dependent targets seems solving the ordering of the options passed to the compiler, but I suspect that there is another small error somewhere else that originates the problem.

Otherwise the installed headers are included before those of the build tree
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants