Fix include directories in SWIG bindings #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise the installed headers are included before those of the build tree
traversaro
approved these changes
May 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, the first
-Icompiler option passed to compile the bindings is a system folder, and if the CMake project is installed, the installed headers are included in the bindings. This is not a big problem in most cases, but it could create problems when the public headers change while developing because SWIG would generate the bindings with the installed ones instead of the new in-source updated headers.This minor change of dependent targets seems solving the ordering of the options passed to the compiler, but I suspect that there is another small error somewhere else that originates the problem.