Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/wrong elbow name and forearm sensors ref link #22

Merged
merged 2 commits into from
Aug 18, 2016
Merged

Fix/wrong elbow name and forearm sensors ref link #22

merged 2 commits into from
Aug 18, 2016

Conversation

nunoguedelha
Copy link
Contributor

This change fixes issue #21.

@nunoguedelha
Copy link
Contributor Author

@traversaro

@traversaro
Copy link
Member

Tests are failing with :

[ERROR] Specified sensor type imu of imu is not recognised, parsing failed.icub-model-test error: base_link test performed correctly 

icub-model-test error: sole are parallel test performed correctly 

[ERROR] Specified sensor type imu of imu is not recognised, parsing failed.[ERROR] Specified sensor type imu of imu is not recognised, parsing failed.[ERROR] ModelLoader :: loadModelFromFile : Error in parsing sensors from URDF.

Perhaps we need to make the sensor-parser in iDynTree more tolerant to not recognized sensor types.

traversaro added a commit to robotology/idyntree that referenced this pull request Aug 15, 2016
@traversaro
[urdf] Transform not recognized URDF sensor type from error to warning
30013f9 
See robotology/icub-models-generator#22 .
@traversaro traversaro mentioned this pull request Aug 15, 2016
Merged
@traversaro
Copy link
Member

Build restarted after robotology/idyntree#208 .

@traversaro
Copy link
Member

Tests are passing, merging.

@traversaro traversaro merged commit 8565324 into master Aug 18, 2016
@traversaro traversaro deleted the fix/wrong_ElbowName_and_forearmSensorsRefLink branch August 18, 2016 22:03
traversaro added a commit to robotology/idyntree that referenced this pull request Aug 20, 2016
@traversaro
[urdf] Transform not recognized URDF sensor type from error to warning
9c1ee0a 
See robotology/icub-models-generator#22 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nunoguedelha @traversaro