Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix location of collision element in iCubGazeboV3 model #251

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Fix location of collision element in iCubGazeboV3 model #251

merged 1 commit into from
Sep 20, 2023

Commits on Sep 20, 2023

  1. Fix location of collisions element in iCubGazeboV3 model 

    Fix robotology/icub-models#209 .

In #243 the location of the frames of the links of the soles ( with names like `(r|l)_foot_(front|back)` ) have been moved to the origin of the FT sensors that connect them with the `(r|l)_ankle_2` link. All the quantities expressed in this frame have been automatically modified to account for its new location by the simmechanics-to-urdf script, except for the location of the assigned collision, that are hardcoded in the .yaml file . This created a regression, has it effectly moved the sole assigned collisions up, so the robot was actually touching the ground with the (r|l)_ankle_2 links, that do not have any contact parameter assigned.

This commit fixes the situation by taking the existing z value of the assigned collision origin, and adding the offset with which the other elements (visual, inertial) have been modified 
(see robotology/icub-models@799ae07#diff-9d811d6ae4a80f936a2466cdc3b852ac4fb6d6e3a4cd40d2c42e794f42d6415aL260), to obtain:

newCollisionZ = oldCollisionZ + (newVisualZ - oldVisualZ)
              = 0.003         + (0.9241470000000105     - 0.9464470000000105    )
              = -0.0193
    @traversaro
    traversaro authored Sep 20, 2023
    Configuration menu
    Copy the full SHA
    12fc95d View commit details
    Browse the repository at this point in the history