Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added component configurations for new wrist and hand #95

Merged
merged 3 commits into from
Jun 29, 2021

Conversation

ale-git
Copy link
Contributor

@ale-git ale-git commented Jun 29, 2021

I've added component configurations (new Mk 3 hand and Mk 2 wrist at present) to icub-models.

Short recap:

  • we have added a components folder to https://github.com/robotology/icub-models-generator that contains parts not yet mounted on complete robots, such as the new 4 finger hand and the parallel wrist
  • the URDF models are generated as usual, and copied to icub-models with their related configuration files in the robots folder
  • differently from the robot models, only one gazebo version is generated in icub-models for those components, and so the model.config generation must be treated in a different way - basically it only needs to update the model version, and thus:
  • the CONFIGURED_MODELS list contains the components that not requires further configuration of the model.config apart from the version.

@traversaro

This comment has been minimized.

@@ -50,6 +50,10 @@ list(APPEND GAZEBO_SUPPORTED_MODELS "iCubGazeboV2_5")
list(APPEND GAZEBO_SUPPORTED_MODELS "iCubGazeboV2_5_plus")
list(APPEND GAZEBO_SUPPORTED_MODELS "iCubGazeboV3")

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ale-git can you provide a short comment explaining what the variable CONFIGURED_MODELS contains? From the CMake code it is not obvious that for the models contained in CONFIGURED_MODELS the model.config for use in Gazebo will be generated, but without generating the helper models _fixed and _feet_fixed. For people that modify this is in the future, it may be useful to have at least a short comment describing what the CONFIGURED_MODELS variable is, or to use a more descriptive name.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @traversaro I've added the comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@traversaro traversaro merged commit 3ab2ce6 into robotology:devel Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants