Add Octave Mex support #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Related issue: #190 . |
|
An update to the documentation is coming in the next PR, for the time being if you want to try the Octave bindings you just need to add the |
|
If no one has comments I will merge this PR this evening. |
|
Ready to merge, and the tests are already running in Travis! |
This should avoid problems such as #307
This was referenced Jun 6, 2017
traversaro
added a commit
that referenced
this pull request
Jun 6, 2017
For some reason, Octave tests started failing in master. Given that we will soon merge `devel` in `master` and in the `devel` the bindings for Octave changed completely (see #305), I think for the time being we can just disable testing the Octave bindings in master.
traversaro
added a commit
that referenced
this pull request
Jun 7, 2017
For some reason, Octave tests started failing in master. Given that we will soon merge `devel` in `master` and in the `devel` the bindings for Octave changed completely (see #305), I think for the time being we can just disable testing the Octave bindings in master.
traversaro
added a commit
to robotology/yarp-matlab-bindings
that referenced
this pull request
Jun 14, 2017
* Port improvements from iDynTree in robotology/idyntree#305 . This includes full Octave support. * Stop including a copy of yarp.i locally, and just use the upstream copy of yarp.i (depends on robotology/yarp#1270)
traversaro
added a commit
to robotology/yarp-matlab-bindings
that referenced
this pull request
Jun 14, 2017
* Port improvements from iDynTree in robotology/idyntree#305 . This includes full Octave support. * Stop including a copy of yarp.i locally, and just use the upstream copy of yarp.i (depends on robotology/yarp#1270)
This was referenced Jun 14, 2017
traversaro
pushed a commit
that referenced
this pull request
Jun 30, 2017
* added primatic joint to CMAKE * added primatic joint to urdf model import * added primatic joint * minor change * prismatic joint source and header * primatic joint included in unit test * minor fix * included prismatic joint * translation methods added to axis class * variable name changes * translation transform clean up * minor fix * minor fix - setting transform rotation using Identity() * translation transform derivative changes * translation transform derivative - rotation derivative set to zero * minor fix - unused parameter commented * minor fix-indentation * prismatic resetAxisBuffers * [travis] Disable testing of Octave bindings in master For some reason, Octave tests started failing in master. Given that we will soon merge `devel` in `master` and in the `devel` the bindings for Octave changed completely (see #305), I think for the time being we can just disable testing the Octave bindings in master. * Fix big size of dox generation * minor fix - comma followed space correction * minor fix * Add release notes on prismatic joint support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for compiling the mex interface that we have been using for over an year with Matlab.
This is done by solving (probably not with the best possible solution) #188 and updating the used version of swig-matlb to the latest version available at https://github.com/jaeandersson/swig , to exploit all the improvements explained in jaeandersson/swig#67 .
This has the following advantages over the existing octave bindings, that use the system version of Swig to create bindings that use the C++ interface of Octave:
iDynTree;before being able to use the bindings.As a downside, the mex-based bindings of Octave are probably slower than the one based on the C++ octave interface, but I think it is a downside with which we can cope, as Octave will be typically used for testing or for running calibration routines such as the one in https://github.com/robotology-playground/sensors-calib-inertial on the PC of the robots).
My idea (for the reason explained in the PR) is to merge this version of the bindings (even if there are some existing issues: ) , and in a short time remove completely from the repo the support for building the C++ Octave bindings, and just least to the user the possibility to compile the mex-based Octave bindings.
cc @francesco-romano @nunoguedelha @diegoferigo @gabrielenava @fjandrad @S-Dafarra
*Please note that this PR will need to be re-generate the bindings (with the new commit jaeandersson/swig@260ed47, as documented in the README) but I will commit the auto-generated files just before merging to simplify the review of the PR.