-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI support for macos-14 Apple Silicon #1589
Conversation
CI fails with:
So #1573 is not working as expected. |
The debug print prints:
so I guess we are installing the wrong mambaforge? |
Indeed we were using an old |
To actually have Apple Silicon CI, for the MATLAB part we need to also add msdk files for Apple Silicon. |
Same problem with v3, let's try to directly pass the install file as suggested in conda-incubator/setup-miniconda#312 (comment) . |
First errors in blocktestcore:
Probably we can disable ROBOTOLOGY_ENABLE_TESTING (for this error) and ROBOTOLOGY_ENABLE_ICUB_HEAD (as it requires ace) for now. |
Now we reached an error related to that:
|
Cool, disabling ICUB_HEAD, ROBOT_TESTING and MATLAB the CI on Apple Silicon is successful in ~23 minutes: https://github.com/robotology/robotology-superbuild/actions/runs/7718783179/job/21040755061 . |
ROBOTOLOGY_ENABLE_ICUB_HEAD support is blocked by conda-forge/ace-feedstock#29, while I opened robotology/blocktest#66 to track the problem blocking |
There are still some CMake failures in finding Matlab, but it seems related to old FindMatlab.cmake files hanging around, see #1044 for the issue tracking that. |
Stable branch passing: https://github.com/robotology/robotology-superbuild/actions/runs/7738402350/job/21099140928?pr=1589 . The Unstable branch is not passing, probably we have a few repo still on devel, it could make sense to just use master on all those low dev repos. |
Finally green, merging. |
Thanks @traversaro, I am sure I will be among those who will benefit from this. |
Fix #1231 .
Fix #916 .
macos-14 is Apple Silicon, see https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/ . I also changed
macos-latest
tomacos-12
, as nowmacos-latest
is an alias formacos-12
(see https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories) and it is a bit confusing otherwisefyi @DanielePucci, that should reduce possible regressions for Apple Silicon users in the future.