Incorrect iteration over multiple selected namespaces

[theboringstuff]

Describe the bug
When multiple namespaces are specified using -n option, e.g. -n ns1 -n ns2, KRR iterates these namespaces inconsistently, sometimes skipping some namespaces. For example, it lists deployments for ns1 only and statefulsets for ns2 only.

I suppose this code should bind namespace variable early before lambda (not late inside), e.g.

                tasks = [
                    loop.run_in_executor(
                        self.executor,
                        lambda ns=namespace: namespaced_request(
                            namespace=ns,
                            watch=False,
                            label_selector=settings.selector,
                        ),
                    )
                    for namespace in settings.namespaces
                ]

To Reproduce
Steps to reproduce the behavior:

1. Create two namespaces, each with one Deployment and one StatefulSet
2. Run KRR simple -n ns1, you will see 2 recommendations
3. Run KRR simple -n ns2, you will see 2 recommendations
4. Run KRR simple -n ns1 -n ns2. I expect to see 4 recommendations, but in fact there will be less (e.g. only 2).

[aantn]

Yep, you seem to be correct. Very nice catch.

Would you be interested in opening a PR to fix?

[LeaveMyYard]

Thanks @theboringstuff, good catch