-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KRR computes recommendation for lots of Kubernetes objects, but if just one errors out no results are printed #301
Comments
Strongly in favor of a fix! It would be best to do it on top of the prometheus-workload-loader branch as that has some major changes that will be merged soon. We would love to receive a PR for this. |
Hey, I had an easy test case for this so I fixed it myself. Please test and confirm that this works. |
Note that the fix isn't merged yet - it is on #307 |
@aantn it works for me! thanks for this fix!!! |
Wonderful, happy to hear it! |
Describe the bug
KRR computes recommendations for lots of Kubernetes objects but if just one errors out, no useful results are printed.
To Reproduce
Steps to reproduce the behavior:
krr simple
INFO Calculated recommendations for ...
lines are printed, if one object errors out, none of these recommendations are printed, only the error/traceback is printed.Expected behavior
A partial result is printed with the recommendations of the objects for which KRR was able to compute, and a list of errors for the objects that had errors.
Are you interested in contributing a fix for this?
Yes!!
Desktop (please complete the following information):
The text was updated successfully, but these errors were encountered: