Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor strategy dependancy on metrics #116

Merged
merged 7 commits into from
Aug 2, 2023
Merged

Refactor strategy dependancy on metrics #116

merged 7 commits into from
Aug 2, 2023

Conversation

LeaveMyYard
Copy link
Contributor

Now strategy defines itself the list of required metrics. Metrics are now loaded dynamically based on that.

Avi-Robusta
Avi-Robusta requested changes Aug 1, 2023
View reviewed changes
Copy link
Contributor

@Avi-Robusta Avi-Robusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good,
The query needs to be fixed for max cpu
and we don't get the graphs in the output json format

@LeaveMyYard LeaveMyYard merged commit d202105 into main Aug 2, 2023
1 check passed
@LeaveMyYard LeaveMyYard deleted the strategy-metric-usage-refactoring branch August 2, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Avi-Robusta Avi-Robusta Avi-Robusta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeaveMyYard @Avi-Robusta