Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix listing namespaced workflows #122

Merged
merged 6 commits into from
Aug 10, 2023
Merged

Fix listing namespaced workflows #122

merged 6 commits into from
Aug 10, 2023

Conversation

LeaveMyYard
Copy link
Contributor

Similar to #48, This allows non-admin users on RBAC enforced clusters to run krr.

This allows non-admin users on RBAC enforced clusters to run krr.

It does this by:

  • Adding a new CLI flag called "resources" which allows users to only
    run krr on specific resources.
  • Using namespaced functions in the k8s python client library
    where specific namespaces are being queried.

Thanks to @mnbbrown for initial PR

@LeaveMyYard LeaveMyYard linked an issue Aug 9, 2023 that may be closed by this pull request
Copy link
Contributor

@Avi-Robusta Avi-Robusta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good,
A few questions.
add small change to resource validator

@LeaveMyYard LeaveMyYard merged commit 842d97e into main Aug 10, 2023
1 check passed
@LeaveMyYard LeaveMyYard deleted the namspaces-filtering-fix branch August 10, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to run on specific namespaces with restricted permission
2 participants