Fallback to K8S API for getting pods, refactor logging for new warnings #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 6, 2023
Closed
LeaveMyYard
changed the title
aantn
reviewed
Oct 9, 2023
aantn
reviewed
Oct 9, 2023
aantn
reviewed
Oct 9, 2023
arikalon1
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fallback to loading pods from KubeAPI in case some error occured with prometheus.
Raise a warning, as this results in missing some pods from the total calculation.
Note: previously (<= 1.4) KRR was loading pods from the API, and then loading deleted ones from prometheus (as only prometheus keeps track of historical objects). 1.5 introduced an optimization of loading everything only from prometheus, but some users (#127 (comment)) seem to not have some required metrics.
Added a section in a readme, describing what metrics are required to be present on a Prometheus, add a link to that in a CLI warning