Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor k8s workloads streaming #256

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Refactor k8s workloads streaming #256

merged 2 commits into from
Apr 4, 2024

Conversation

LeaveMyYard
Copy link
Contributor

Remove streaming of workloads to simplify the code

@LeaveMyYard LeaveMyYard requested a review from aantn April 3, 2024 10:07
@LeaveMyYard LeaveMyYard self-assigned this Apr 3, 2024
aantn
aantn approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@aantn aantn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Before merging can you:

  1. Look into the pytest failure
  2. Verify on a test cluster that output on this branch is identical to output on main before this change?

Thanks!

@LeaveMyYard
Copy link
Contributor Author

Just checked: the only thing that slightly changes with this update is the ordering of workloads, which is OK.

(Previously could have been Deployment, Rollout, Statefullset, Daemonset, now it is Deployment, Rollout, Daemonset, Statefullset)

@LeaveMyYard LeaveMyYard merged commit 76ed553 into main Apr 4, 2024
2 checks passed
@LeaveMyYard LeaveMyYard deleted the refactor-workloads-streaming branch April 4, 2024 10:41
@aantn
Copy link
Contributor

aantn commented Apr 4, 2024

Awesome, good work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aantn aantn aantn approved these changes

Assignees

@LeaveMyYard LeaveMyYard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeaveMyYard @aantn