-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAIN-2169] Prometheus preformance fix #1563
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avi-Robusta
commented
Sep 19, 2024
Avi-Robusta
commented
Sep 19, 2024
Avi-Robusta
commented
Sep 19, 2024
Avi-Robusta
force-pushed
the
prometheus_preformance_fix
branch
from
September 23, 2024 13:24
a0f3dc5
to
97b9fc8
Compare
Avi-Robusta
changed the title
[DONT MERGE] Prometheus preformance fix - Needs new prometrix release before merge
[MAIN-2169] Prometheus preformance fix
Sep 23, 2024
arikalon1
reviewed
Sep 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
left some comments
Clarifying the types here @arikalon1 |
arikalon1
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We updated prometrix for faster preformance.
https://pypi.org/project/prometrix/0.2.0/
There were issues with speed and cpu when serialising the Hikaru object.
you can see the speed improvements here
As you can see it is used practically in the same way but now needs some slight changes
query_result.vector_result[0].value
we need to usequery_result.vector_result[0]["value"]
Tests ran