more e2e tests #112
Merged
more e2e tests #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fault e2e test for with/without fec
gavv
reviewed
Aug 30, 2023
roc/e2e_test.go
Outdated
| samplesCnt := 100 | ||
| testSamples := generateTestSamples(samplesCnt) | ||
|
|
||
| var interval = time.Second / time.Duration(44100/samplesCnt) |
There was a problem hiding this comment.
nit: Let's use sample rate from config, instead of 44100?
gavv
added
needs revision
ortex
force-pushed
the
more_e2e_tests
branch
5 times, most recently
from
bdec9e1
to
98d9865
Compare
ortex
force-pushed
the
more_e2e_tests
branch
from
98d9865
to
f22a239
Compare
|
@gavv Could you have a look? fixed the discussion and set go-version to 1.20 instead of the latest because our ci pipeline fails with new go 1.21, see https://github.com/roc-streaming/roc-go/actions/runs/6067814352 I will create a separate issue for that Btw, need to use '1.20' as go version for action instead of 1.20, because 1.20 is treated as 1.2 actions/setup-go#326 (comment) |
ortex
added
ready for review
|
Thanks! Damn, it was float! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add e2e TestEnd2End_Blocking for ClockInternal clock source; split default e2e test for with/without fec
#102 #104