Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualize vector of RGBs #65

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Visualize vector of RGBs #65

wants to merge 7 commits into from

Conversation

shoppel
Copy link

@shoppel shoppel commented Dec 1, 2015

Allows to visualize vectors of RGBs, fixes some bugs (crash if a model could not be loaded), does some formatting and adapts the order of the methods within header and source file (reason why so much changes are shown).

Images can be load as textures again, but bump mapping is still not available (remove completely?).

@doudou
Copy link
Member

doudou commented Dec 7, 2015

This is getting ... too much IMO. Why not create a different plugin that uses this one as children ?

As for bump mapping, I'm using this, why do you want to remove it ?

@shoppel
Copy link
Author

shoppel commented Mar 29, 2016

I keep getting asked for the RGB vector visualization. Ok there are lots of changes (btw. mostly because of the formatting commit) but alltogether it is just a cleaned up, more stable version (e.g. no crashes if any path is wrong). Putting it in another viz plugin would just double the code.. The bump mapping did not work for me and I could not imagine any meaningful use-case, so I did not include it yet.

Maybe you can test und pull this nevertheless?

@shoppel
Copy link
Author

shoppel commented Mar 29, 2016

Ok and I took care that the header and the source file use the same method order, this created lots of changes as well (without changing anything).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants