Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: define the "prepare" lifecycle hook #263

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: define the "prepare" lifecycle hook #263

wants to merge 1 commit into from
+40 −3

Conversation

doudou
Copy link
Member

@doudou doudou commented Nov 29, 2023

So far we had

setup
controller (== run)
shutdown
cleanuṕ

The shutdown pair did not exist. Create it in this commit

@doudou
feat: define the "prepare" lifecycle hook
66c30a0 
So far we had

    setup
    controller (== run)
    shutdown
    cleanuṕ

The shutdown pair did not exist. Create it in this commit
wvmcastro
wvmcastro approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@wvmcastro wvmcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make this need more tangible by giving an example where it is needed/useful?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvmcastro wvmcastro wvmcastro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@doudou @wvmcastro