WIP/RFC extract framerate #62
Conversation
| @@ -144,6 +144,8 @@ MPP_RET mpp_frame_info_cmp(MppFrame frame0, MppFrame frame1) | |||
| (f0->height == f1->height) && | |||
| (f0->hor_stride == f1->hor_stride) && | |||
| (f0->ver_stride == f1->ver_stride) && | |||
| (f0->time_scale == f1->time_scale) && | |||
There was a problem hiding this comment.
There is no necessary to add info change test. For framerate change will reflect on pts.
The info change judgement will report resolution / bitdepth / format changes which will affect buffer allocation and display setup.
There was a problem hiding this comment.
Yes I had doubts about where to put the information and how to have the parser notify the app when those values change. What do you think would be the best way ?
There was a problem hiding this comment.
There should be demux before mpp ( codec ). So demuxer can know the change.
When use mpp alone without demux embeded the frame rate change can be detect by pts gap.
These frame rate information looks like ffmpeg style : )
There was a problem hiding this comment.
In fact, we're already in the process moving away from PTS-based detection of framerate changes, and on our side the need for this patch is temporary. If you feel it's not the right place for the feature, let's just close this PR, and we'll just keep this patch on our side until our need for it is gone :)
This builds on #61 to get notifications when the frame-rate encoded in SPS changes.
This is very preliminary, adding h264-specific fields in generic structures. I noticed that some work had been done about those fields in the h265 decoder, but the data-structures are missing. We'll have to deal with h265 too in the near future. How can we proceed ? Are you interested with adding this feature ?