Support for Atmega88 #68
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rocketscream
requested changes
Sep 14, 2018
|
Hello,
Yes, I would do it. Also I would like to know if I should remove any added comments like "MOD TG 14 09 2018".
SIncerely
…________________________________
De : rocketscream <[email protected]>
Envoyé : 14 septembre 2018 05:59:40
À : rocketscream/Low-Power
Cc : Thierry GUENNOU; Author
Objet : Re: [rocketscream/Low-Power] Support for Atmega88 (#68)
@rocketscream requested changes on this pull request.
Do you mind pulling the latest revision to make the changes? You are using 1.60 instead of 1.70.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#68 (review)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AdqCD0RvusdPmqybCx90F0niwb6xfx22ks5ua6g8gaJpZM4Wivsp>.
|
Sorry but I think I made a mistake on V1.70 as it was merged from a pull request without me checking the release note section which was not update. The code was updated.
Yes, please remove it and it supposed to be added to the top portion of the release note section. The V1.70 for ATmega1284P and ATmega644P was missing. |
|
Hello,
I don't see any change on https://github.com/rocketscream/Low-Power after June 3 ...
Sincerely
[https://avatars2.githubusercontent.com/u/822826?s=400&v=4]<https://github.com/rocketscream/Low-Power>
rocketscream/Low-Power: Low Power Library for Arduino - GitHub<https://github.com/rocketscream/Low-Power>
github.com
Join GitHub today. GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
…________________________________
De : rocketscream <[email protected]>
Envoyé : 14 septembre 2018 22:46:25
À : rocketscream/Low-Power
Cc : Thierry GUENNOU; Author
Objet : Re: [rocketscream/Low-Power] Support for Atmega88 (#68)
Yes, I would do it.
Sorry but I think I made a mistake on V1.70 as it was merged from a pull request without me checking the release note section which was not update. The code was updated.
Also I would like to know if I should remove any added comments like "MOD TG 14 09 2018".
Yes, please remove it and it supposed to be added to the top portion of the release note section. The V1.70 for ATmega1284P and ATmega644P was missing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#68 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AdqCDyKKHkybcZzGr4lIqGbWyYrsjzpiks5ubJQxgaJpZM4Wivsp>.
|
|
Hello, I downloaded the 1.7 version but the header is still 1.6. That must be the reason for the confusion. I don't pull request for now but wait for your validation of the 1.7 version. Sincerely |
|
Okay, fixed with 6cfe933. Sorry for the confusion. |
|
Hello,
I prepared the release but the commit shows all lines different due to line ending problem. I work on Windows and edit them with TextPad.
I don't have the Github client but download / upload from Github.
I don't know how to handle this properly with regards to how you do.
What should I do?
Sincerely
…________________________________
De : rocketscream <[email protected]>
Envoyé : 26 septembre 2018 08:47:27
À : rocketscream/Low-Power
Cc : Thierry GUENNOU; Author
Objet : Re: [rocketscream/Low-Power] Support for Atmega88 (#68)
Okay, fixed with 6cfe933<6cfe933>. Sorry for the confusion.
Do bump the revision to V1.80.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#68 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AdqCDzr7X0PMiXGydFWf0vN2ZfEVwzuLks5ue6GPgaJpZM4Wivsp>.
|
You may decide to give Notepad++ a go, it has options to manipulate line endings automagically. |
|
Hello,
Thanks for the info. I will consider it for a next upload. But it did not seem to be a problem when you merged the pull request... why? Was it transparent to you?
…________________________________
De : Stefan Langer <[email protected]>
Envoyé : 8 octobre 2018 11:37:44
À : rocketscream/Low-Power
Cc : Thierry GUENNOU; Author
Objet : Re: [rocketscream/Low-Power] Support for Atmega88 (#68)
Hello, I prepared the release but the commit shows all lines different due to line ending problem. I work on Windows and edit them with TextPad. I don't have the Github client but download / upload from Github. I don't know how to handle this properly with regards to how you do. What should I do? Sincerely
You may decide to give Notepad++ a go, it has options to manipulate line endings automagically.
https://notepad-plus-plus.org/
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#68 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AdqCD3NF_1YoiR6tAu9cpUI6IHOTOKP3ks5ui5t4gaJpZM4Wivsp>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Just a few changes to support Atmega88/Atmega88A. LowPower BOD is not supported with this MCU.