Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade backbone #1484

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Upgrade backbone #1484

wants to merge 3 commits into from

Conversation

sfranzen
Copy link
Contributor

@MFlyer
Copy link
Member

MFlyer commented Oct 16, 2016

@schakrava Travis?? 😄 🎉

@sfranzen
Copy link
Contributor Author

Yay I failed the first Travis build! 😛 It only checked for Ruby :(

@sfranzen
Copy link
Contributor Author

Hmm, my last commit is not the right way. Will probably revert it and instead insert this.options = options || {}.

Newer versions of Backbone no longer implicitly attach these
to the view, so the relevant initialize functions now do so
explicitly.
@schakrava
Copy link
Member

@sfranzen Since upgrading backbone pretty much effects every part of the UI, can you tell us if/how you've tested this for potential regressions?

@priyaganti
Copy link
Contributor

Hello @sfranzen Thanks for the PR. I have pulled your changes and tested it on my VM but found out that the UI doesn't work as expected.
Here are some of the bugs that I have noticed.

  1. The Disks page doesn't display a table. Its a blank section with navbar and sidebar.
    emptydiskspage
  2. When I click on Create Pool button instead of the form I get an empty page.
  3. Disks table inside the resize pool wizard is empty.
    disktablepoolresize
  4. Clicking on submit to start a new scrub or balance doesn't show the table of scrubs and balances.
  5. Share resize form works but the changed values are not displayed on the screen.

These are only a few of them and I see a lot more of them. I think it needs some more testing and fixing up.
Please take a look when you get time. Just wanted to give some feedback as I came across this PR. Cheers!

@schakrava
Copy link
Member

Thanks @priyaganti . @sfranzen, please rebase with latest master. This is an important change and I appreciate your contribution, just needs a bit more testing. good luck!

@phillxnet
Copy link
Member

This pr can sever to inform an updating to our backbone libs and use, post our testing branch creation.
This is expected to take place shortly as we move towards releasing our first v4 "Built on openSUSE" stable version.

@phillxnet
Copy link
Member

phillxnet commented Aug 15, 2024

From: https://github.com/jashkenas/backbone/tags the latest release of Backbone (https://backbonejs.org/) is now at 1.6.0 (5th Feb 2024).

Changelog: https://backbonejs.org/#changelog

From which we have the main update requirement addressed in this PR, introduced in 1.1.0:

Backbone Views no longer automatically attach options passed to the constructor as this.options and Backbone Models no longer attach url and urlRoot options, but you can do it yourself if you prefer.


Re-iterating that this PR depends on rockstor/rockstor-jslibs#8 which proposed an update to 1.3.3 (Apr. 5, 2016)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants