This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 151
Fix problem shutting down interfaces with names like wlan0-foobar sin… #109
Open
knro
wants to merge
24
commits into
rockymeza:master
Choose a base branch
from
knro:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New wrappers for manipulating hostapd and dnsmasq configuration files and an AccessPoint class that combines hostapd, dnsmasq and scheme in order to set up an access point with dhcp, dns forwarding, local domain resolution and optionally also NATing to an existing interface. Also adds support for static interfaces. New dependency on the netaddr module had to be added in order to make the ip network handling for the access point mode less cumbersome. Scheme now also support overwriting of existing configurations and more than one entry per configuration key in extended options (necessary for adding iptables/sysctl calls for post-up/pre-down events in /etc/network/interfaces).
Forgot to adjust some expected values after switching scheme to multidicts, sorry, fixed now.
…tion script Trying to install that stuff (if target location is writable) when being installed as a dependency causes a sandbox violation in easy_install which cannot be circumvented as it seems. So only install bash completion if explicitely invoked to do via "python setup.py install_extras". With "python setup.py uninstall_extras" it's also possible to uninstall.
…d by AccessPoint Forgot to add a convenience method for that, will be needed though if lib clients want to override the default paths.
Should hopefully get rid of the timing issues when bringing up dnsmasq on AP start
…m as a connection error
…ls with error code
…unction Since we also handle WPA keyphrases as plain text keyphrases, it makes sense to equally preprocess the entered data from the user here too, instead of forcing him to manually add s: in front of plain text keyphrases. Alternatively the documentation should hint the user that this is necessary.
Conflicts: tests/test_schemes.py
…ce iface includes the complete name
Hi @knro, I'm sorry. I am no longer going to be maintaining the wifi project. Thanks for your pull request, but unless somebody wants to take over maintenance, I don't know if it will get merged. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is probably related to this issue: #102
Shutting down interfaces with compounded names like wlan0-XXXX fails since .interface does not include the full name like .iface