Adding sudo args #75
Adding sudo args #75
Conversation
| kwargs = {'stderr':subprocess.STDOUT} | ||
| scheme = Scheme('wlan0', 'test') | ||
| subprocess.check_output = MagicMock(return_value=SUCCESSFUL_IFUP_OUTPUT) | ||
| scheme.activate(True) |
There was a problem hiding this comment.
Can you write this as scheme.activate(sudo=True). I want the recommended interface to use the keyword argument instead of the kwargs.
There was a problem hiding this comment.
should I do the same for cell.all in scan.py?
Erf-
force-pushed
the
adding-sudo-args
branch
7 times, most recently
from
7579355
to
1c2775b
Compare
| @@ -278,3 +282,15 @@ def test_scanning(self): | |||
| Encryption key:off | |||
| Bit Rates:144 Mb/s | |||
| """ | |||
|
|
|||
| output = string.join([IWLIST_SCAN_NO_ENCRYPTION, | |||
There was a problem hiding this comment.
" ".join() should work, not need for importing string
|
Please also revert the file mode changes. |
Erf-
force-pushed
the
adding-sudo-args
branch
9 times, most recently
from
d1d423f
to
973de9b
Compare
|
Hi Rocky. I tried to match what you and Yohan Boniface told me to do. Then can you check my latest version. |
| @@ -13,8 +13,8 @@ def read(fname): | |||
|
|
|||
|
|
|||
| install_requires = [ | |||
| 'setuptools', | |||
|
Ok, I had just a few comments. After those are resolved let's merge this baby. Thanks for all the hard work @Erf- and thanks for the extra review help @yohanboniface. |
Add sudo args to terminal calls. modified : tests/test_parsing.py modified : tests/test_scan.py modified : tests/test_schemes.py removed : wifi/dummydata.py modified : wifi/scheme.py Pull request fix #1. modifié : tests/test_scan.py modifié : tests/test_schemes.py Pull request fix #2. modifié: tests/test_scan.py modifié: tests/test_schemes.py Pull request fix rockymeza#3. modifié: setup.py Add 'mock' to the requires. Pull request fix rockymeza#4. modifié: .travis.yml Demand for latest update of setuptools when installing. Pull request fix rockymeza#5. Improve code readability. Add Travis to my own repository. Restore file permissions. Pull request fixes rebase. Rebase of the pull request fixes in order to clear the code and to solve build issues.
|
I made the review in a commit amend to avoid polluting the pull request. |
As you can see I splited my previous pull request. Then this one only implement the adding of 'sudo' args in terminal calls and the related tests. Note there is one failure in the tests i did not succeed to solve yet.