CHANGELOG: Highlight the subtlety of the Function Call breaking change

[dylanahsmith]

Problem

@newhook pointed out the problem on slack

I just figured out another upgrade issue I ran into...

func (fn *Function) Call(args ...Valuer) (*Value, error) {

Changed to:

func (fn *Function) Call(recv Valuer, args ...Valuer) (*Value, error) {

That is a bit of subtle breaking change since the code continues to compile, it just doesn't work like at all. I wonder if the release notes could make that little more obvious?

Solution

Add a couple more sentences to that changelog for that change to mention how old code will compile but the first argument would be reinterpreted and mention how to fix it. Using the bold words subtle breaking change should help it stand out from other changes.

[codecov]

Codecov Report

Merging #259 (a8bcaef) into master (943fcf9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #259   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          17       17           
  Lines         583      583           
=======================================
  Hits          559      559           
  Misses         15       15           
  Partials        9        9           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 943fcf9...a8bcaef. Read the comment docs.