Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ScrollYOffset reset when not using a selector #163

Merged
merged 2 commits into from
Apr 4, 2022
Merged

Fix ScrollYOffset reset when not using a selector #163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f785170
fix offset disable when not using selector
jeff1010322 Apr 4, 2022
501e98c
docs(changeset): fix scrollYOffset disable when not using selector
jeff1010322 Apr 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fuzzy-panthers-wink.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'docusaurus-theme-redoc': patch
---

fix scrollYOffset disable when not using selector
7 changes: 5 additions & 2 deletions packages/docusaurus-theme-redoc/src/utils/useSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,11 @@ export function useSpec({ spec, url }: SpecProps) {
const { lightTheme, darkTheme, options: redocOptions } = themeOptions;

const commonOptions: Partial<RedocRawOptions> = {
// Disable offset when server rendering
scrollYOffset: isBrowser ? redocOptions.scrollYOffset : 0,
// Disable offset when server rendering and set to selector
scrollYOffset:
!isBrowser && typeof redocOptions.scrollYOffset === 'string'
? 0
: redocOptions.scrollYOffset,
};

// eslint-disable-next-line @typescript-eslint/no-explicit-any
Expand Down