New option for a different primary color in dark mode #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some primary colors don't work well in both dark and light contexts. This allows the user to configure a different primary color in dark mode, in hopefully the most backwards-compatible way (it will always default to the value we already have for primary color).
🦋 Changeset detectedLatest commit: 54cf0a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Someone is attempting to deploy a commit to a Personal Account owned by @rohit-gohri on Vercel. @rohit-gohri first needs to authorize it. |
|
@rohit-gohri do I need to split this into multiple commits or something? |
rohit-gohri
reviewed
Jul 16, 2022
rohit-gohri
approved these changes
Jul 16, 2022
rohit-gohri
changed the title
Merged
|
Hey @benbrandt thanks for the ping! I lost this PR in the notifications. Released now. Thanks for the PR (and updating the docs!!) ! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some primary colors don't work well in both dark and light contexts.
This allows the user to configure a different primary color in dark
mode, in hopefully the most backwards-compatible way (it will always
default to the value we already have for primary color).