Merge pull request #241 from stanhu/sh-strip-query-string-from-location

Strip query string from the log for Location headers
roidrage · Mar 28, 2018 · 82ead88 · 82ead88
2 parents 3b61c61 + aefae1e
commit 82ead88
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/lograge/log_subscriber.rb b/lib/lograge/log_subscriber.rb
@@ -53,6 +53,10 @@ def initial_data(payload)
 
     def extract_path(payload)
       path = payload[:path]
+      strip_query_string(path)
+    end
+
+    def strip_query_string(path)
       index = path.index('?')
       index ? path[0, index] : path
     end
@@ -104,7 +108,7 @@ def extract_location
       return {} unless location
 
       RequestStore.store[:lograge_location] = nil
-      { location: location }
+      { location: strip_query_string(location) }
     end
 
     def extract_unpermitted_params

diff --git a/spec/lograge_logsubscriber_spec.rb b/spec/lograge_logsubscriber_spec.rb
@@ -167,7 +167,7 @@
 
     context 'with a redirect' do
       before do
-        RequestStore.store[:lograge_location] = 'http://www.example.com'
+        RequestStore.store[:lograge_location] = 'http://www.example.com?key=value'
       end
 
       it 'adds the location to the log line' do