-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add LTSV formatter #138
Add LTSV formatter #138
Conversation
fec9c29
to
c1d8382
Compare
format code styles and squashed commit |
Thank you for the PR 👍 |
@pxlpnk thank you for reviewing! fixed file name with |
c1d8382
to
6745c54
Compare
Looks good. Here we would need some single quotes to make rubocop happy: https://github.com/takashi/lograge/blob/add-ltsv-formatter/spec/formatters/ltsv_spec.rb#L26 @benlovell any objections in merging this? |
6745c54
to
a74cd6b
Compare
@pxlpnk opps, my bad. format style and squashed! |
LGTM. 👍 build failed on |
@benlovell thx for LGTM! but i think the reason of failure on jruby-head is different from this PR's change. WDYT? |
Yep agreed. It's unrelated. |
@benlovell yep, but I cant merge without resolving this issue... ;( |
upps, mistake for closing |
Well you've triggered another build now so that's useful 😄 |
a74cd6b
to
90f856c
Compare
I opened an issue on the jRuby repo, lets see if we get any pointers on this: jruby/jruby#3102 For the rest, I am fine with merging it and adding One wish is to change the commit message to |
90f856c
to
71ad31b
Compare
@pxlpnk thanks for opening issue in jruby :) And I fixed commit message by capitalizing |
@pxlpnk how about this PR? |
@benlovell okay thanks! I merged the commit that allows failure for jruby-head into this PR 👍 |
ebc8f6c
to
8b48d62
Compare
@benlovell I see, and I rebased merge commit 👍 If i misunderstand your opinion, please let me know |
Rebase is perfect. A capitalized |
@pxlpnk upps, i forgot to capitalize |
8b48d62
to
ec5102e
Compare
🚢 |
😍 thanks |
thx for merging! |
I added a new formatter which formats log with LTSV format
LTSV means "Labeled Tab-separated Values"
official site: http://ltsv.org/
The LTSV format focuses on access logs of web servers
and I think it is useful for logging.