Add support for Rails 5.0.0.beta2
#166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benlovell
force-pushed
the
rails-5
branch
2 times, most recently
from
966026f
to
949979d
Compare
benlovell
changed the title
5.0.0.beta25.0.0.beta2
Thankfully, Rails 5 support was mostly a drop-in change. It did however, require some build shuffling to support JRuby. Rack 2 alpha now requires `2.2.2` support as minimum. Unfortunately, jrubies pre-9000 didn't support `2.2.2` we'll need to explicitly build against `9.0.4.0`. We'll still provide support for JRuby of older vintages, but given Rack's needs this won't extend to Rails 5 also. Closes #165.
benlovell
changed the title
5.0.0.beta25.0.0.beta2
I noticed I'd incorrectly formatted the last few entries. Turns out GitHub flavoured markdown isn't interpreted in regular markdown files. I'll correct these in a separate PR.
benlovell
added a commit
that referenced
this pull request
Feb 21, 2016
Add support for Rails `5.0.0.beta2`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thankfully, Rails 5 support was simply a drop-in change.
Testing this in a basic sample application yields the expected results.